Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[envtest]Use infra helpers from infra-operator #551

Merged
merged 1 commit into from
Oct 3, 2023
Merged

[envtest]Use infra helpers from infra-operator #551

merged 1 commit into from
Oct 3, 2023
+43 −39

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Sep 29, 2023

This is necessary to remove a dependency cycle from lib-common

@openshift-ci openshift-ci bot requested review from abays and bogdando September 29, 2023 08:51
@gibizer
Copy link
Contributor Author

gibizer commented Sep 29, 2023

/hold waiting for deps

@gibizer gibizer mentioned this pull request Sep 29, 2023
Merged
11 tasks
@gibizer
[envtest]Use infra helpers from infra-operator
f07ce68 
This is necessary to remove a dependency cycle from lib-common
@gibizer gibizer force-pushed the infra-test-helpers branch from de93bd6 to f07ce68 Compare October 2, 2023 07:56
@gibizer
Copy link
Contributor Author

gibizer commented Oct 2, 2023

/retest cert manager issue is fixed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

@gibizer: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test functional
  • /test images
  • /test precommit-check

The following commands are available to trigger optional jobs:

  • /test nova-operator-build-deploy
  • /test nova-operator-build-deploy-tempest

Use /test all to run all jobs.

In response to this:

/retest cert manager issue is fixed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gibizer
Copy link
Contributor Author

gibizer commented Oct 2, 2023

/retest
cert manager issue is fixed

@gibizer
Copy link
Contributor Author

gibizer commented Oct 2, 2023

/test nova-operator-build-deploy

@gibizer
Copy link
Contributor Author

gibizer commented Oct 2, 2023

/test nova-operator-build-deploy-tempest

@gibizer
Copy link
Contributor Author

gibizer commented Oct 2, 2023

/unhold

@gibizer
Copy link
Contributor Author

gibizer commented Oct 2, 2023

/test nova-operator-build-deploy-tempest

mrkisaolamb
mrkisaolamb approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@mrkisaolamb mrkisaolamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrKisaoLamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gibizer,mrKisaoLamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 0cde993 into openstack-k8s-operators:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkisaolamb mrkisaolamb mrkisaolamb approved these changes

@abays abays Awaiting requested review from abays

@bogdando bogdando Awaiting requested review from bogdando

Assignees

@mrkisaolamb mrkisaolamb

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gibizer @mrkisaolamb